remove blank string hack to skip tick labels

plotly · Apr 1, 2022 · 0734767a35a9ad7d0d211b50971a80035a7f8ce1 · 0734767
1 parent 0774d15
commit 0734767a35a9ad7d0d211b50971a80035a7f8ce1
Showing with 62 additions and 62 deletions.

+2 −2 src/plots/cartesian/axes.js

+60 −60 test/jasmine/tests/axes_test.js
diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -946,7 +946,7 @@ axes.calcTicks = function calcTicks(ax, opts) {
 
     var lastVisibleHead;
     var hideLabel = function(tick) {
-        tick.text = ' '; // don't use an empty string here which can confuse automargin (issue 5132)
+        tick.text = '';
         ax._prevDateHead = lastVisibleHead;
     };
 
@@ -3008,7 +3008,7 @@ axes.drawLabels = function(gd, ax, opts) {
     var axLetter = axId.charAt(0);
     var cls = opts.cls || axId + 'tick';
 
-    var vals = opts.vals;
+    var vals = opts.vals.filter(function(e) { return e.text; });
 
     var labelFns = opts.labelFns;
     var tickAngle = opts.secondary ? 0 : ax.tickangle;